feat(iaas): onboard routing-table command#1339
Open
h3adex wants to merge 3 commits intostackitcloud:mainfrom
Open
feat(iaas): onboard routing-table command#1339h3adex wants to merge 3 commits intostackitcloud:mainfrom
h3adex wants to merge 3 commits intostackitcloud:mainfrom
Conversation
7 tasks
marceljk
reviewed
Mar 12, 2026
marceljk
reviewed
Mar 12, 2026
marceljk
reviewed
Mar 12, 2026
marceljk
reviewed
Mar 12, 2026
marceljk
reviewed
Mar 12, 2026
marceljk
reviewed
Mar 12, 2026
marceljk
reviewed
Mar 12, 2026
marceljk
reviewed
Mar 12, 2026
marceljk
reviewed
Mar 13, 2026
marceljk
reviewed
Mar 13, 2026
efb03b8 to
5954fd9
Compare
5954fd9 to
642ed2e
Compare
marceljk
reviewed
Mar 13, 2026
Contributor
marceljk
left a comment
There was a problem hiding this comment.
Just tested the new routing-tables commands and they work like a charm. The only issue I found was that the label-selector isn't correctly set in the request and so the flag doesn't work as intended.
Beside that the PR is approved from my side 😃
| func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiListRoutingTablesOfAreaRequest { | ||
| request := apiClient.ListRoutingTablesOfArea(ctx, model.OrganizationId, model.NetworkAreaId, model.Region) | ||
| if model.LabelSelector != nil { | ||
| request.LabelSelector(*model.LabelSelector) |
Contributor
There was a problem hiding this comment.
It's call by value so you must set the request variable with the return value. Add also a test case to cover this
Suggested change
| request.LabelSelector(*model.LabelSelector) | |
| request = request.LabelSelector(*model.LabelSelector) |
rubenhoenle
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Onboards routing-table command
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)