Skip to content

feat(iaas): onboard routing-table command#1339

Open
h3adex wants to merge 3 commits intostackitcloud:mainfrom
h3adex:feat/iaas-add-routing-table-command
Open

feat(iaas): onboard routing-table command#1339
h3adex wants to merge 3 commits intostackitcloud:mainfrom
h3adex:feat/iaas-add-routing-table-command

Conversation

@h3adex
Copy link
Contributor

@h3adex h3adex commented Mar 11, 2026

Description

Onboards routing-table command

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@h3adex h3adex force-pushed the feat/iaas-add-routing-table-command branch from efb03b8 to 5954fd9 Compare March 13, 2026 09:23
@h3adex h3adex force-pushed the feat/iaas-add-routing-table-command branch from 5954fd9 to 642ed2e Compare March 13, 2026 09:30
Copy link
Contributor

@marceljk marceljk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested the new routing-tables commands and they work like a charm. The only issue I found was that the label-selector isn't correctly set in the request and so the flag doesn't work as intended.
Beside that the PR is approved from my side 😃

func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiListRoutingTablesOfAreaRequest {
request := apiClient.ListRoutingTablesOfArea(ctx, model.OrganizationId, model.NetworkAreaId, model.Region)
if model.LabelSelector != nil {
request.LabelSelector(*model.LabelSelector)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's call by value so you must set the request variable with the return value. Add also a test case to cover this

Suggested change
request.LabelSelector(*model.LabelSelector)
request = request.LabelSelector(*model.LabelSelector)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants